Github user smarthi commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/81#discussion_r76514978
--- Diff:
src/main/java/org/apache/pirk/schema/data/partitioner/PrimitiveTypePartitioner.java
---
@@ -32,7 +32,7 @@
* Class for partitioning objects with primitive Java types
*
*/
-public class PrimitiveTypePartitioner implements DataPartitioner
+final public class PrimitiveTypePartitioner implements DataPartitioner
--- End diff --
Nitpick: How 'bout public final class :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
