[
https://issues.apache.org/jira/browse/PIVOT-471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Brown resolved PIVOT-471.
------------------------------
Resolution: Fixed
This is fixed. These methods now all return an instance of ImmutableList, which
is iterable. I have also added Javadoc explaining that the returned list is a
wrapper, so callers know what to expect.
I did not apply the toString() patch. ListSelection is a package-private class,
so only platform code would be able to call this. However, if you describe the
problem you are trying to solve, maybe there is another way it could be
handled. Could you simply call toString() on the returned list? That will
ultimately delegate to the source array list within the ListSelection instance.
> Make TableView.getSelectedRanges() iterable
> -------------------------------------------
>
> Key: PIVOT-471
> URL: https://issues.apache.org/jira/browse/PIVOT-471
> Project: Pivot
> Issue Type: Wish
> Components: wtk
> Reporter: Dirk Moebius
> Priority: Minor
> Fix For: 1.5
>
> Attachments: ListSelection_toString.patch.txt
>
>
> Iterating over the results of TableView.getSelectedRanges() is cumbersome
> because it returns a Sequence<Span> which is not iterable using a for-each
> loop. Instead it should return a List<Span>, which is iterable. Javadoc
> should state that the returned List is immutable.
> Likewise for:
> - ListView.getSelectedRanges()
> - TreeView.getSelectedPaths()
> - FileBrowser.getSelectedFiles()
> - FileBrowserSheet.getSelectedFiles()
> JavaDoc of TableView.getSelectedRows() should clearly state that this is a
> convenience method only, and that it allocates a result array on each
> invocation. Likewise for ListView.getSelectedItems().
> See
> http://mail-archives.apache.org/mod_mbox/pivot-user/201004.mbox/%[email protected]%3e
> for motivation of this issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
