The branch has been created. This means that if you're working on a 1.5.1 feature, you'll need to submit it to both the 1.5.x branch and the trunk. 1.6+ features should just be added to the trunk.
-T On Mon, Jun 7, 2010 at 11:09 AM, Greg Brown <gkbr...@mac.com> wrote: > I was thinking we'd create it from trunk. > > > ----- Reply message ----- > From: "Todd Volkert" <tvolk...@gmail.com> > Date: Mon, Jun 7, 2010 11:03 am > Subject: [RFC] adding components to TextArea > To: <dev@pivot.apache.org> > > > Should the 1.5.x branch be created from the 1.5 tag or from the current > trunk? > > -T > > On Mon, Jun 7, 2010 at 9:33 AM, Greg Brown <gkbr...@mac.com> wrote: > > > I think that traversing the view hierarchy again is OK. > > > > Also, I think we should probably consider creating a 1.5.x branch at this > > point. That will allow us to continue making fixes to the 1.5 tree but > will > > also allow you to check in your code. > > > > On Jun 7, 2010, at 9:24 AM, Noel Grandin wrote: > > > > > Hi > > > > > > OK, I've reworked the patch so that it calculates position during > > > layout(), but I had to traverse the NodeView hierarchy again in order > to > > > do that. > > > > > > Regards, Noel. > > > > > > > > > Greg Brown wrote: > > >>> I have to do it this way because TextAreaSkin only calculates > position > > >>> information during paint(). > > >>> > > >> I don't think that's accurate. It should be calculated in layout(), > when > > validate() is called on the document view. You should be able to > > position/size the components after that call. > > >> > > >> > > >> > > > > > > <patch2.txt> > > > > > > >
