I noticed that existing comments seem to be hacked around quite a lot by the Eclipse formatting profile, but assumed that was because the code pre-dated the profile, or was not written in Eclipse.
Another option would be to have a pre-commit Ant task which would perform a trim-whitespace, format any changed files and any other relevant tasks. I don't know if it is possible to do that and limit it to just the blocks of code identified by a diff or something similar. Chris On 17 September 2010 02:12, Greg Brown <[email protected]> wrote: > OTOH, a better approach might be to simply review the formatter thoroughly > so we don't have to worry about this at all. I'll try to find some time to > do that. > > On Sep 16, 2010, at 3:05 PM, Greg Brown wrote: > > > Hi all, > > > > Just a code style request - please don't apply the code formatter to > existing code unless it is really necessary. Although the formatter works > pretty well, I often still manually tweak the formatting for the sake of > readability. Applying the formatter generally blows away all of the manual > edits. :-( > > > > Also, I noticed that there is at least one issue with the formatter - it > currently places a space between the cast operator and the operand, which we > don't want: > > > > (Foo) bar (BAD) > > > > vs. > > > > (Foo)bar (GOOD) > > > > I'll post an updated version to the wiki. > > > > Thanks, > > Greg > > > >
