Thanks Roger. I noticed the QueryServlet one in trunk on Friday night but didn't have time to address it before breaking for the weekend.
I'm sure there that somewhere there is a document fully explaining the policy for accepting patches, but for now I can't locate one. In it absence I'll quote Todd Volkert from a recent mail. > FYI, we're legally obliged to have you submit any potential patches > through JIRA, because the act of checking the license grant checkbox > is important from a legal perspective. http://apache-pivot-developers.417237.n3.nabble.com/Re-Best-practice-for-implementing-Actions-tp1447175p1448665.html I don't think there is a need for you to resubmit this patch (unless you really want to!) as it is just a warning and should be caught during test builds in the pre-release process (if not well before). Thanks anyway though. Regards, Chris On 20 September 2010 23:36, Roger L. Whitcomb <[email protected]>wrote: > Actually there is another one in the latest head revs of 1.5.x: > [javadoc] > C:\Projects\Pivot\svn\branches\1.5.x\web-server\src\org\apache\pivot\web > \server\QueryServlet.java:236: warning - Tag @link: can't find > validate(Path) in org.apache.pivot.web.server.QueryServlet > > Roger Whitcomb | Architect, Engineering | [email protected] | > Ingres | 500 Arguello Street | Suite 200 | Redwood City | CA | 94063 | > USA +1 650-587-5596 | fax: +1 650-587-5550 > -----Original Message----- > From: Roger L. Whitcomb [mailto:[email protected]] > Sent: Monday, September 20, 2010 9:25 AM > To: [email protected] > Subject: Small bug in 1.5.x in Javadoc > > Hi, > > I was generating Javadoc in the 1.5.x branch and I > noticed this warning: > > [javadoc] Building tree for all the packages and classes... > > [javadoc] > C:\Projects\Pivot\svn\branches\1.5.x\wtk\src\org\apache\pivot\wtk\conten > t\TreeBranch.java:116: warning - @param argument > > "expandedIconURL" is not a parameter name. > > > > Here is the patch to fix this: > > Index: wtk/src/org/apache/pivot/wtk/content/TreeBranch.java > > =================================================================== > > --- wtk/src/org/apache/pivot/wtk/content/TreeBranch.java (revision > 997887) > > +++ wtk/src/org/apache/pivot/wtk/content/TreeBranch.java (working > copy) > > @@ -108,7 +108,7 @@ > > * application context's {...@linkplain > ApplicationContext#getResourceCache() > > * resource cache} if one does not already exist. > > * > > - * @param expandedIconURL > > + * @param expandedIconName > > * The resource name of the expanded icon to set. > > * > > * @see #setExpandedIcon(URL) > > > > > > > > Roger Whitcomb > > Architect, Engineering > > Ingres Corporation > > [email protected] <mailto:[email protected]> > > > > PHONE +1 650.587.5596 > > FAX +1 650.587.5550 > > > > www.ingres.com <http://www.ingres.com/> > > > > This transmission is confidential and intended solely for the use of the > recipient named above. It may contain confidential, proprietary, or > legally privileged information. If you are not the intended recipient, > you are hereby notified that any unauthorized review, use, disclosure or > distribution is strictly prohibited. If you have received this > transmission in error, please contact the sender by reply e-mail and > delete the original transmission and all copies from your system. > > > >
