[
https://issues.apache.org/jira/browse/PIVOT-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913513#action_12913513
]
Sandro Martini commented on PIVOT-245:
--------------------------------------
> Why not add a new signature with the multiplier and have the existing
> signature delegate to it with the default multiplier?
Ok, I wasn't sure that changing an existing behavior was accepted, so I'll try
your suggestion.
The problem is that existing methods (brighten and darken) are static, so I
have to keep the new variable static (colorMultiplier), and I don't like this
too much ... but otherwise the change would be more complex, so this proposal
is good for me.
> In Skin json file, add optional coefficients for darkening and brightening
> base colors
> --------------------------------------------------------------------------------------
>
> Key: PIVOT-245
> URL: https://issues.apache.org/jira/browse/PIVOT-245
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Reporter: Sandro Martini
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.0
>
> Attachments: patch.txt
>
>
> Could be useful to add (also in the json file):
> optional coefficients for darkening and brightening base colors, otherwise
> the default of the theme (in Terra it's + / - 10%) will be used.
> Because on some color schemes the default it's not enough ... I've just seen
> with my dark scheme.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
