I've reverted Component and changed the property to a simple boolean named 'debugfocus' which applies a red shade decorator. r1001051 & r1001045
On 25 September 2010 00:50, Greg Brown <[email protected]> wrote: > I don't want to be needlessly nit-picky. I myself would probably just use a > shade decorator (or perhaps a hypothetical border decorator) with a fixed > color and call the flag "debugfocus". But if you prefer the choice of > colors, I am fine with that. > > On Sep 24, 2010, at 1:38 PM, Chris Bartlett wrote: > > > On 25 September 2010 00:10, Greg Brown <[email protected]> wrote: > > > >>>> Also, as a user, I think I might find it odd that I need to specify a > >> color > >>>> when really I just want the debug focus behavior. > >>> > >>> I'm not sure I agree that a user would find it odd if the property was > >> named > >>> debugfocuscolor and the documentation specified that it accepted one of > X > >>> values to give them flexibility. > >> > >> As a user, I'd first expect to see a flag that enabled debug focus > >> behavior, and then possibly an optional flag to control the color. > >> > > Having made the call to offer a choice of colours, and that the 'debug' > > behaviour would be off by default, having 2 properties seemed overkill. > > In other situations, of course what you are saying makes sense. > > > > > >>>> Also, as Sandro pointed out, any hard-coded color may work well in > some > >>>> schemes but not in others. > >>>> > >>> Hence 3 colors. I was aware of the work that you and Sandro had been > >> doing > >>> on different color schemes. > >> > >> Right, but the issue isn't color - it's contrast. That's why XOR mode > would > >> help. It always draws in a contrasting color. > >> > > Yep, I understand. Again I was just trying to keep things simple while > > offering some flexibility. > > > > Shall I continue with a ShadeDecorator, or would you rather something > else? > >
