[ 
https://issues.apache.org/jira/browse/PIVOT-712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002675#comment-13002675
 ] 

Andrei Pozolotin commented on PIVOT-712:
----------------------------------------

Greg:

thanks for getting back;

* re: "existing Ant script and file structure works well" 
- if people ask for it, chances are it does not work for them :-)

* I come from "a possible new contributor" perspective;
here is my brief report of "trying to contribute" to pivot:

* I must do all in maven as a matter of policy, especially when I see pom.xml 
in your trunk;
I expect to open all pivot projects with single m2e-plugin-provided click:
"eclipse -> import -> import existing maven projects"
instead I have to import 12 eclipse-centric projects (which cause name 
collisions);

* pivot eclipse project names "web" "tutorials" "examples" "tests" 
cause collision in my eclipse workspace and force me 
to use a separate workspace just to take a look at pivot code;

* maven artifact names vs maven module names vs eclipse project names are 
inconsistent;
I suggest you have the following modules listed in your parent pom.xml
<modules>
<module>pivot-charts</module>
<module>pivot-core</module>
<module>pivot-demos</module>
<module>pivot-demos-server</module>
<module>pivot-examples</module>
<module>pivot-tests</module>
<module>pivot-tutorials</module>
<module>pivot-tutorials-server</module>
<module>pivot-web</module>
<module>pivot-web-server</module>
<module>pivot-wtk</module>
<module>pivot-wtk-terra</module>
</modules>
and also rename all eclipse projects and all svn folders
this takes care of name collision and other maven compatibility issues in the 
long run
(like maven release plugin)

* pivot artifacts in maven central are "illegal"
since they depend on the private / broken dependency 
http://repo1.maven.org/maven2/com/kitfox/svg/svg-salamander/1.0/

* Mark McKay 
http://www.kitfox.com/
basically needs little help to publish svg-salamander properly 
to maven central to remedy this;

* instead of / in addition to relying of class path setup via eclipse .project
I suggest to include explicit pom.xml dependencies for the jars you keep in 
/lib folders

* I suggest to have all your projects/modules have normal pom.xml in them

* the requirement in your BUILD instructions:
"
* Ensure that the LiveConnect APIs are on your classpath (set the CLASSPATH
  environment variable accordingly):
"
is resolved by pom entry like this: (no need to mess with class path manually)
                <!-- provides browser interaction -->
                <dependency>
                        <groupId>com.sun.jdk</groupId>
                        <artifactId>plugin</artifactId>
                        <version>1.6.0</version>
                        <type>jar</type>
                        <scope>system</scope>
                        <systemPath>${java.home}/lib/plugin.jar</systemPath>
                </dependency>

* as an example, recent holy war of ant-builders vs maven-builders here:
http://code.google.com/p/google-guice/
resulted in this:
- guice is mavenized;
- both ant and maven builders work;
- "cool geeks from google" continue to build their private builds manually with 
ant;
- "totally boring developers" like me use hudson-based daily-produced 
auto-build from sonatype:
https://repository.sonatype.org/content/groups/forge/org/sonatype/sisu/sisu-guice/3.0-SNAPSHOT/

* I would hope that if you mavenized pivot you could setup hudson based 
auto-build 
http://java.net/projects/hudson/
and could provide daily maven SNAPSHOT releases, so people like me 
do not have to build pivot myself and yet have access to all latest 
fixes/features
in their production projects, via repo such as this:
https://docs.sonatype.org/display/Repository/Sonatype+OSS+Maven+Repository+Usage+Guide

thank you;

Andrei.


> mavenize pivot build
> --------------------
>
>                 Key: PIVOT-712
>                 URL: https://issues.apache.org/jira/browse/PIVOT-712
>             Project: Pivot
>          Issue Type: Improvement
>          Components: project
>            Reporter: Andrei Pozolotin
>              Labels: PIVOT-389
>
> Greg, hello;
> you mentioned in PIVOT-389 that you do not care for maven much;
> please let me know if you open to the idea to mavenize pivot build 100% 
> so you can actually open and build all pivot projects in eclipse 
> with help of m2e http://www.eclipse.org/m2e/
> ?
> currently I have to hack all your pom.xml to get the deseired result;
> thank you;
> Andrei.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to