[ 
https://issues.apache.org/jira/browse/PIVOT-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050524#comment-13050524
 ] 

Sandro Martini commented on PIVOT-742:
--------------------------------------

Hi Andrei, 
don't get me wrong, your solution is more useful than my (little hack) in 
PIVOT-687 ... probably you have reason, and it's better to handle the case of 
PIVOT-687 (that's not a common use case) in another way (like you proposed in 
your previous comment, only we have to see where to put that code ... not in 
BXMLSerializer, maybe in another utility class).
So could be safe even to remove the BXMLSerializer with the Classloader as 
parameter (new in 2.0.1).
And then update the PIVOT-687 ticket with the latest changes.

Greg, what do you think ?


> pluggable classloader
> ---------------------
>
>                 Key: PIVOT-742
>                 URL: https://issues.apache.org/jira/browse/PIVOT-742
>             Project: Pivot
>          Issue Type: Improvement
>            Reporter: Andrei Pozolotin
>            Assignee: Sandro Martini
>             Fix For: 2.0.1
>
>         Attachments: CLPlugin.java, CLPluginTCCL.java, CLProvider.java, 
> UseCase.java, patch_2011-06-15_bxml-classloader.patch
>
>
> pluggable classloader:
> 1) in current pivot trunk, TCCL, 
> Thread.currentThread().getContextClassLoader().... is mentioned 105 times
> I suggest to centralize it and replace with pluggable classloader (which can 
> use TCCL by default);
> 2) review all other uses of Class.getResource(), which are not using TCCL, 
> and convert when possible;
> motivation:
> https://issues.apache.org/jira/browse/PIVOT-22
> https://issues.apache.org/jira/browse/FELIX-2951
> http://njbartlett.name/2010/08/30/osgi-readiness-loading-classes.html 
> http://wiki.eclipse.org/index.php/Context_Class_Loader_Enhancements
> http://stackoverflow.com/questions/2198928/better-handling-of-thread-context-classloader-in-osgi
> http://mail-archives.apache.org/mod_mbox/pivot-user/201105.mbox/%3c4dcdf889.10...@gmail.com%3E

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to