[
https://issues.apache.org/jira/browse/PIVOT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13780709#comment-13780709
]
Karel Hübl commented on PIVOT-916:
----------------------------------
Sandro, thanks for the fix.
To prevent the problem with not intitalizing the disp variable, you can make
the startUp method final and create new non final method for overriding. Also
the disp variable could be protected. However JavaDoc should be sufficient...
public static class Adapter implements Application, UncaughtExceptionHandler {
protected Display disp;
@Override
public final void startup(Display display, Map<String, String>
properties) throws Exception {
this.disp = display;
startupInternal(display, properties);
}
public void startupInternal(Display display, Map<String, String> properties)
throws Exception {}
...
> Replace DesktopApplicationContext.displayException calls with
> ApplicationContext.handleUncaughtException
> --------------------------------------------------------------------------------------------------------
>
> Key: PIVOT-916
> URL: https://issues.apache.org/jira/browse/PIVOT-916
> Project: Pivot
> Issue Type: Improvement
> Reporter: Karel Hübl
> Assignee: Sandro Martini
> Fix For: 2.0.4
>
> Attachments: trunk_wtk.patch, wtk_test.zip
>
>
> There should be consistent way to handle uncaught exceptions in Pivot
> applications.
> However uncaught exceptions thrown in DesktopApplicationContext class (for
> example in application.startup ) are handled using private static method
> displayException, which displays dialog and its logic cannot be overriden.
> May be ApplicationContext.handleUncaughtException could be made protected and
> calls to DesktopApplicationContext.displayException could be replaced by
> ApplicationContext.handleUncaughtException. And possibly Application.Adapter
> could implement UncaughtExceptionHandler - so current
> DesktopApplicationContext.displayException logic could be moved to new
> Application.Adapter.uncaughtExceptionThrown method.
> This should enable to override uncaught exception handling globally in pivot
> applications.
> Motivation:
> We deploy Pivot app using Java Web Start. Users have by default disabled Java
> Console (and they are not familiar with it). We want to display custom dialog
> to handle uncaught exceptions displaying full stack trace and with possiblity
> to report exception to help desk.
> I think, in current implementation it is not possible to override handling of
> uncaught exceptions thrown during application init and other specific
> situations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
