[
https://issues.apache.org/jira/browse/PIVOT-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985295#comment-13985295
]
Sandro Martini commented on PIVOT-947:
--------------------------------------
Hi Roger, the patch looks good.
On the general solution, I too doesn't have a clear idea on how we could
improve the extension of standard pivot components ... getSkin() not public is
by design and it's safer, so as you I think a good compromise for now could be
to expose as public only desired properties (as usual via getter/setter
methods).
A general solution (in a related jira issue) could be a big point to be revised
for 2.5 ... I have others (more event publish/subscribe) for 2.5 to discuss.
> Add hooks to VFS File Browser to add controls
> ---------------------------------------------
>
> Key: PIVOT-947
> URL: https://issues.apache.org/jira/browse/PIVOT-947
> Project: Pivot
> Issue Type: Improvement
> Components: wtk, wtk-terra
> Affects Versions: 2.1
> Environment: All
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Minor
> Fix For: 2.1
>
> Attachments: 947.diffs
>
>
> In my use of the VFSBrowser and VFSBrowserSheet classes, I need to add some
> extra controls that are not in the regular dialog, such as a button to switch
> modes and extra label fields in the Sheet. So, there needs to be hooks in
> order to do this (this is similar to what was added earlier to the regular
> file browser sheet to add a character set selection).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
