[
https://issues.apache.org/jira/browse/PIVOT-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14106663#comment-14106663
]
Sandro Martini commented on PIVOT-689:
--------------------------------------
Committed revision 1619713 (and a small simplification if 1619715):
add defaultBackgroundColor and defaultForegroundColor in Terra Theme json
config file (to be able to set them) with a good fallback value. Note that even
in general Theme there are (general) default values for them.
As a sample, add some (very visible: red, and yellow) values for them.
Now I guess if it would be useful to define these values even in
TerraTheme_default.json (and maybe even in TerraTheme_dark.json) files, for two
reasons:
- have a sample of its usage (without having to look at code), for our users
- check if change these values, at least in the TerraTheme_default.json file
(to reduce the whitening effect just seen) ...
Comments ?
> Finishing touches on Skin Colors
> --------------------------------
>
> Key: PIVOT-689
> URL: https://issues.apache.org/jira/browse/PIVOT-689
> Project: Pivot
> Issue Type: Improvement
> Components: wtk-terra
> Reporter: Sandro Martini
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.1, 2.0.5
>
> Attachments: ColorSchemeBuilder - dark.launch, ComponentExplorer -
> dark.launch, KitchenSink - Dark.launch, pivot689.patch
>
>
> Finishing touches on Skin Colors, some info here (and more later here in
> JIRA): https://issues.apache.org/jira/browse/PIVOT-579
> See if even the final part of this (not implemented) could be useful:
> https://issues.apache.org/jira/browse/PIVOT-245
> And there was another discussion (I have to find where, in nabble) is change
> some color index usage to have better visual appearance (of course
> retrofitting existing behavior when/if possible).
> Note that probably after these little changes, custom color json files should
> be a little updated.
> And a little thing on this:
> now only Tooltips doesn't use a palette color (they use an hard-coded color)
> ... what do you think to make them use the yellow-ish color at
> palette index 19 (or one of is variants, the 18 or 20) ? And use a similar
> (yellow-ish but a different color index, if possible) color on warnings.
> I could adapt a little that color in all Pivot palettes to look similar to
> what should be ... tell me.
> For example, someone remember the background color in Swing Tooltips (ok not
> the best in graphic design and colors :-) ), but with this little change we
> could also have this little feature, where in most palettes will be
> yellow-ish, but where needed could be different.
> Added some documentation in the Terra package JavaDoc file on color palette
> usage in the Terra Skin, to help anyone wants to write their custom colors,
> and then removed, probably the best place for this is in a Tutorial.
> Last, in ColorSchemeBuilder (and maybe even in the Kitchen Sink), add some
> Tooltips to see how they happen, but see where they makes sense.
> And maybe in ColorSchemeBuilder move some elements in the Tab2 or Tab3,
> grouping them by similar components (some componets should be added there).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
