[
https://issues.apache.org/jira/browse/PIVOT-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14109297#comment-14109297
]
Sandro Martini edited comment on PIVOT-689 at 8/26/14 4:52 PM:
---------------------------------------------------------------
Just cleaned up a few (unnecessary) override in colors in sample_content.bxml
(loaded by ColorSchemeBuilder), and note that if I change the styles of
ScrollPane (of Tab 1) from backgroundColor:null, for example to something very
visible like backgroundColor:'#ff0000', I see what is really causing a lot of
whitening there ...
Note that after changing palette colors, only contents inside Tabs is shown
changed (because it's reloaded) so all other parts still use original colors
... and consistence in color usege even here is ok.
Then, the second issue is related to the second color of default palette too
much white (if I try to lowering it, i see things inside the tab, darkening as
background, ok) ... now we could think to adjust a little that color (for
example from 255,255,255 to 250,250,250 or similar, and the same for first
color 0,0,0 to 5,5,5), or even increase the difference, like 245,245,245 and
10,10,10 for example.
I can look at old (2.0.x) appearance and try to get a similar visual result.
Last, after these changes I still see some areas white at top and bottom left,
but it's the default skin backgound color, now configurable, ok.
I think it would be good to add a default even for this in skin default config
file like the previous ...
What do you think ?
was (Author: smartini):
Just cleaned up a few (unnecessary) override in colors in sample_content.bxml
(loaded by ColorSchemeBuilder), and note that if I change the styles of
ScrollPane (of Tab 1) from backgroundColor:null, for example to something very
visible like backgroundColor:'#ff0000', I see what is really causing a lot of
whitening there ...
Then, the second issue is related to the second color of default palette too
much white (if I try to lowering it, i see things inside the tab, darkening as
background, ok) ... now we could think to adjust a little that color (for
example from 255,255,255 to 250,250,250 or similar, and the same for first
color 0,0,0 to 5,5,5); I can look at old (2.0.x) appearance and try to get a
similar visual result.
Last, after these changes I still see some areas white at top and bottom left
(probably it's the default skin backgound color, but now it's configurable :-)
) ... I'll make some checks even on this, and if it is, I think it would be
good to add a default even for this in skin default config file like the
previous ...
Now I can make some tests, commit "safe" changes, and add an updated screen
shot here ...
What do you think ?
> Finishing touches on Skin Colors
> --------------------------------
>
> Key: PIVOT-689
> URL: https://issues.apache.org/jira/browse/PIVOT-689
> Project: Pivot
> Issue Type: Improvement
> Components: wtk-terra
> Reporter: Sandro Martini
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.1, 2.0.5
>
> Attachments: ColorSchemeBuilder - dark.launch, ComponentExplorer -
> dark.launch, KitchenSink - Dark.launch, pivot689.patch
>
>
> Finishing touches on Skin Colors, some info here (and more later here in
> JIRA): https://issues.apache.org/jira/browse/PIVOT-579
> See if even the final part of this (not implemented) could be useful:
> https://issues.apache.org/jira/browse/PIVOT-245
> And there was another discussion (I have to find where, in nabble) is change
> some color index usage to have better visual appearance (of course
> retrofitting existing behavior when/if possible).
> Note that probably after these little changes, custom color json files should
> be a little updated.
> And a little thing on this:
> now only Tooltips doesn't use a palette color (they use an hard-coded color)
> ... what do you think to make them use the yellow-ish color at
> palette index 19 (or one of is variants, the 18 or 20) ? And use a similar
> (yellow-ish but a different color index, if possible) color on warnings.
> I could adapt a little that color in all Pivot palettes to look similar to
> what should be ... tell me.
> For example, someone remember the background color in Swing Tooltips (ok not
> the best in graphic design and colors :-) ), but with this little change we
> could also have this little feature, where in most palettes will be
> yellow-ish, but where needed could be different.
> Added some documentation in the Terra package JavaDoc file on color palette
> usage in the Terra Skin, to help anyone wants to write their custom colors,
> and then removed, probably the best place for this is in a Tutorial.
> Last, in ColorSchemeBuilder (and maybe even in the Kitchen Sink), add some
> Tooltips to see how they happen, but see where they makes sense.
> And maybe in ColorSchemeBuilder move some elements in the Tab2 or Tab3,
> grouping them by similar components (some componets should be added there).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
