[
https://issues.apache.org/jira/browse/PIVOT-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14506787#comment-14506787
]
Sandro Martini commented on PIVOT-967:
--------------------------------------
Hi Roger,
to me the patch looks good ... did you tried even with our json files
containing "\" (map.json, RowEditorDemo.json) ?
We haven't json files with other control chars, so if you have some time could
you commit a sample (could be useful even for future tests) maybe under tests
subproject ?
If all is ok, go with the commit ...
Thanks a lot.
> JSONSerializer doesn't correctly handle CR characters
> -----------------------------------------------------
>
> Key: PIVOT-967
> URL: https://issues.apache.org/jira/browse/PIVOT-967
> Project: Pivot
> Issue Type: Bug
> Components: core-serialization
> Affects Versions: 2.0.4, 2.1, 2.0.5
> Environment: All, but particularly Windows
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Minor
> Fix For: 2.1, 2.0.5
>
> Attachments: 967.patch
>
>
> The JSON standard (see JSON.org) defines specific escape sequences for the
> following characters: \b, \f, \n, \r, \t and \uxxxx for other control
> characters. But the encoding logic in JSONSerializer doesn't match this list
> (particularly missing \r and not encoding other control characters using
> \uxxxx). The "writeObject" method only recognizes \t and \n and does not
> encode any control character less than 0xFF. The "readString" method seems a
> bit weird also in its handling of control characters in the input.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
