[
https://issues.apache.org/jira/browse/PIVOT-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356208#comment-16356208
]
Roger Whitcomb commented on PIVOT-1020:
---------------------------------------
I think this is the end of this change:
Sending core\test\org\apache\pivot\functional\monad\test\OptionTest.java
Sending demos\src\org\apache\pivot\demos\styles\ColorSchemeBuilderWindow.java
Sending demos\src\org\apache\pivot\demos\text\TextPaneDemo.java
Sending
tutorials\src\org\apache\pivot\tutorials\explorer\tools\ComponentInspectorSkin.java
Sending web\src\org\apache\pivot\web\PutQuery.java
Sending web-server\src\org\apache\pivot\web\server\QueryServlet.java
Sending wtk\src\org\apache\pivot\wtk\Button.java
Sending wtk\src\org\apache\pivot\wtk\Checkbox.java
Sending wtk\src\org\apache\pivot\wtk\DesktopApplicationContext.java
Sending wtk\src\org\apache\pivot\wtk\Form.java
Sending wtk\src\org\apache\pivot\wtk\MenuButton.java
Sending wtk\src\org\apache\pivot\wtk\RadioButton.java
Sending wtk\src\org\apache\pivot\wtk\Style.java
Sending wtk\src\org\apache\pivot\wtk\content\CalendarButtonDataRenderer.java
Sending wtk\src\org\apache\pivot\wtk\content\ColorItem.java
Sending wtk\src\org\apache\pivot\wtk\content\LinkButtonDataRenderer.java
Sending wtk\src\org\apache\pivot\wtk\content\ListViewItemEditor.java
Sending wtk\src\org\apache\pivot\wtk\content\ListViewItemRenderer.java
Sending wtk\src\org\apache\pivot\wtk\content\MenuItemDataRenderer.java
Sending wtk\src\org\apache\pivot\wtk\content\SpinnerItemRenderer.java
Sending wtk\src\org\apache\pivot\wtk\content\TableViewCellRenderer.java
Sending wtk\src\org\apache\pivot\wtk\content\TableViewCheckboxCellRenderer.java
Sending wtk\src\org\apache\pivot\wtk\content\TableViewFileSizeCellRenderer.java
Sending wtk\src\org\apache\pivot\wtk\content\TableViewImageCellRenderer.java
Sending wtk\src\org\apache\pivot\wtk\content\TableViewNumberCellRenderer.java
Sending wtk\src\org\apache\pivot\wtk\content\TableViewRowEditor.java
Sending wtk\src\org\apache\pivot\wtk\content\TableViewTextAreaCellRenderer.java
Sending wtk\src\org\apache\pivot\wtk\content\TreeViewNodeEditor.java
Sending wtk\src\org\apache\pivot\wtk\content\TreeViewNodeRenderer.java
Sending wtk\src\org\apache\pivot\wtk\effects\WatermarkDecorator.java
Sending wtk\src\org\apache\pivot\wtk\skin\ComponentSkin.java
Sending wtk\src\org\apache\pivot\wtk\skin\ScrollPaneSkin.java
Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraAlertSkin.java
Sending
wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraCalendarButtonSkin.java
Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraCalendarSkin.java
Sending
wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraColorChooserButtonSkin.java
Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraColorChooserSkin.java
Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraExpanderSkin.java
Sending
wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraFileBrowserSheetSkin.java
Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraFileBrowserSkin.java
Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraFormSkin.java
Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraFrameSkin.java
Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraListButtonSkin.java
Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraMenuBarItemSkin.java
Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraMenuButtonSkin.java
Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraMenuItemSkin.java
Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraMenuPopupSkin.java
Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraPaletteSkin.java
Sending
wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraSuggestionPopupSkin.java
Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraTabPaneSkin.java
Sending
wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraVFSBrowserSheetSkin.java
Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraVFSBrowserSkin.java
Transmitting file data ....................................................done
Committing transaction...
Committed revision 1823528.
> Introduce a "Style" enum for compile-time checking of style names
> -----------------------------------------------------------------
>
> Key: PIVOT-1020
> URL: https://issues.apache.org/jira/browse/PIVOT-1020
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Minor
> Fix For: 2.1
>
>
> Many places use hard-coded strings for component style names, and a number of
> which are fairly common ("font", "color", "horizontalAlignment"). It would
> reduce the possibility of misspelling of these style names if there were an
> enum for them so that the Java compiler would check spelling instead of
> finding out at runtime that the style name was misspelled.
> This would involve adding methods to Component.StyleDictionary to deal with
> the enum as a key.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
