chrisdutz commented on issue #10: Fixed NPE in S7PlcConnection#close. URL: https://github.com/apache/incubator-plc4x/pull/10#issuecomment-410171496 And I don't agree with Sebastians assumption. Even if it might be the same thread when running in unit-tests (Here we have to write the response to a request manually ans therefore no thread pool can be used), still I don't think that this pattern is invalid. I have seen it when connecting in other code (I didn't invent that pattern). Blocking inside the protocol handler indeed would be bad, but in this case we have to block somewhere, if we want to shut-down gracefully. Another option would be to return the closable future and to wait for that to finish outside of PLC4X, but that would make things needlessly more complex for our users - I think.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
