+1 (binding),

Release information is a nice to have but not sure we should hold up the
release for it?

All checks complete and built with and tested with main PLC4X library on:-

openjdk 11.0.9 2020-10-20
OpenJDK Runtime Environment (build 11.0.9+11-post-Debian-1deb10u1)
OpenJDK 64-Bit Server VM (build 11.0.9+11-post-Debian-1deb10u1, mixed mode,
sharing)

On Wed, Dec 2, 2020 at 4:58 PM Otto Fowler <[email protected]> wrote:

>  -1 (binding)
> the release notes at the top level and in the package have no information
> for this release.
>
> - also: The readme doesn’t specify the versions of:
> java
> maven
> That are supported and should be used.
>
>
>
> From: Christofer Dutz <[email protected]>
> <[email protected]>
> Reply: [email protected] <[email protected]> <[email protected]>
> Date: December 2, 2020 at 15:31:45
> To: [email protected] <[email protected]> <[email protected]>
> Subject:  AW: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.4.0-RC1
>
> +1 (binding)
>
> Chris
>
>
> [OK] Download all staged artifacts under the url specified in the release
> vote email
> [MINOR] Verify the signature is correct
> [OK] Check if the signature references an Apache email address.
> [OK] Verify the SHA512 hashes
> [OK] Unzip the archive
> [OK] Verify the existence of LICENSE, NOTICE, README, RELEASE_NOTES files
> in the extracted source bundle.
> [OK] Verify the content of LICENSE, NOTICE, README, RELEASE_NOTES files in
> the extracted source bundle.
> [OK] Verify the staged source README, RELEASE_NOTE files correspond to
> those in the extracted source bundle.
> [OK] Run RAT externally to ensure there are no surprises.
> [OK] Search for SNAPSHOT references
> [OK] Search for Copyright references, and if they are in headers, make sure
> these files containing them are mentioned in the LICENSE file.
> [OK] Build the project according to the information in the README.md file.
>
> NOTE: We should probably do a PLC4X private Key-Signing party in order to
> have all of us in a secure trust chain to the rest of the foundation.
>
>
> Von: Lukas Ott <[email protected]>
> Datum: Mittwoch, 2. Dezember 2020 um 21:00
> An: [email protected] <[email protected]>
> Betreff: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.4.0-RC1
> Message:
> Apache PLC4X Build-Tools Code-Generation 1.4.0 has been staged under [2]
> and it’s time to vote on accepting it for release.
>
> All Maven artifacts are available under [1]. Voting will be open for
> 72hr.
>
> A minimum of 3 binding +1 votes and more binding +1 than binding -1
> are required to pass.
>
> Repository: https://gitbox.apache.org/repos/asf/plc4x-build-tools.git
> Release tag: releases/code-generation/1.4.0
> Hash for the release tag: {replacethiswiththerealgitcommittag}
>
> Per [3] "Before voting +1 PMC members are required to download
> the signed source code package, compile it as provided, and test
> the resulting executable on their own platform, along with also
> verifying that the package meets the requirements of the ASF policy
> on releases."
>
> You can achieve the above by following [4].
>
> [ ] +1 accept (indicate what you validated - e.g. performed the non-RM
> items in [4])
> [ ] -1 reject (explanation required)
>
>
> [1]
> https://repository.apache.org/content/repositories/orgapacheplc4x-1030
> [2]
>
> https://dist.apache.org/repos/dist/dev/plc4x/build-tools/code-generation/1.4.0/rc1/
> [3]
> https://www.apache.org/dev/release/validation.html#approving-a-release
> [4] https://plc4x.apache.org/developers/release/validation.html
>

Reply via email to