splatch commented on a change in pull request #170:
URL: https://github.com/apache/plc4x/pull/170#discussion_r543318546
##########
File path:
plc4j/drivers/s7/src/main/java/org/apache/plc4x/java/s7/readwrite/protocol/S7ProtocolLogic.java
##########
@@ -69,7 +72,7 @@
*/
public class S7ProtocolLogic extends Plc4xProtocolBase<TPKTPacket> {
- private static final Logger LOGGER =
LoggerFactory.getLogger(S7ProtocolLogic.class);
Review comment:
Got spot, I did not notice it was static. AFAIR slf4j and modern log4j
(even 1.2) recommendation is to use final without static classifier.
##########
File path:
plc4j/drivers/s7/src/main/java/org/apache/plc4x/java/s7/readwrite/protocol/S7ProtocolLogic.java
##########
@@ -69,7 +72,7 @@
*/
public class S7ProtocolLogic extends Plc4xProtocolBase<TPKTPacket> {
- private static final Logger LOGGER =
LoggerFactory.getLogger(S7ProtocolLogic.class);
Review comment:
Good spot, I did not notice it was static. AFAIR slf4j and modern log4j
(even 1.2) recommendation is to use final without static classifier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
