chrisdutz commented on a change in pull request #219: URL: https://github.com/apache/plc4x/pull/219#discussion_r556365532
########## File path: sandbox/plc4py/pyproject.toml ########## @@ -24,6 +24,7 @@ authors = ["Apache PLC4X <[email protected]>"] [tool.poetry.dependencies] python = "^3.8" +numpy = "^1.19" [tool.poetry.dev-dependencies] pytest = "^5.2" Review comment: Wouldn't it be better to put explicit versions in here and not version ranges? (Or is this more like our prerequisite check in PLC4X where we check at least a given version is installed?) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
