thomas169 opened a new pull request #233:
URL: https://github.com/apache/plc4x/pull/233


   1) Changed address string parsing as in last cancel PR null checking of 
token is performed via strlen poxy. Removed timer/sleep features from windows 
versions
   2) Refactoring: reduced variable name verbosity, used more intermediate 
variables, and typically forwarded variable declarations to beginning of 
scopes, plus major refactoring on files relevant to next item.
   3) Added a write->read loopback test for s7 using bool/int8/int16 types
   3a)  Added I think most todos in write.c, drive_s7_packet.c, 
driver_s7_sm_write.c
   
   Note write response return values are not checked (or used), nor tested with 
arrays of a write type, (think it will not work)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to