ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r695052067
########## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/util/Plc4xCommon.java ########## @@ -0,0 +1,149 @@ +package org.apache.plc4x.nifi.util; +import java.util.Map; + +import org.apache.avro.Schema; +import org.apache.avro.SchemaBuilder; +import org.apache.avro.SchemaBuilder.FieldAssembler; +import org.apache.plc4x.java.api.value.PlcValue; +import org.apache.plc4x.java.spi.values.PlcBOOL; +import org.apache.plc4x.java.spi.values.PlcBYTE; +import org.apache.plc4x.java.spi.values.PlcBigDecimal; +import org.apache.plc4x.java.spi.values.PlcBigInteger; +import org.apache.plc4x.java.spi.values.PlcBitString; +import org.apache.plc4x.java.spi.values.PlcCHAR; +import org.apache.plc4x.java.spi.values.PlcDATE; +import org.apache.plc4x.java.spi.values.PlcDATE_AND_TIME; +import org.apache.plc4x.java.spi.values.PlcDINT; +import org.apache.plc4x.java.spi.values.PlcDWORD; +import org.apache.plc4x.java.spi.values.PlcIECValue; +import org.apache.plc4x.java.spi.values.PlcINT; +import org.apache.plc4x.java.spi.values.PlcLINT; +import org.apache.plc4x.java.spi.values.PlcLREAL; +import org.apache.plc4x.java.spi.values.PlcLTIME; +import org.apache.plc4x.java.spi.values.PlcLWORD; +import org.apache.plc4x.java.spi.values.PlcList; +import org.apache.plc4x.java.spi.values.PlcNull; +import org.apache.plc4x.java.spi.values.PlcREAL; +import org.apache.plc4x.java.spi.values.PlcSINT; +import org.apache.plc4x.java.spi.values.PlcSTRING; +import org.apache.plc4x.java.spi.values.PlcSimpleValue; +import org.apache.plc4x.java.spi.values.PlcStruct; +import org.apache.plc4x.java.spi.values.PlcTIME; +import org.apache.plc4x.java.spi.values.PlcTIME_OF_DAY; +import org.apache.plc4x.java.spi.values.PlcUDINT; +import org.apache.plc4x.java.spi.values.PlcUINT; +import org.apache.plc4x.java.spi.values.PlcULINT; +import org.apache.plc4x.java.spi.values.PlcUSINT; +import org.apache.plc4x.java.spi.values.PlcValueAdapter; +import org.apache.plc4x.java.spi.values.PlcValues; +import org.apache.plc4x.java.spi.values.PlcWCHAR; +import org.apache.plc4x.java.spi.values.PlcWORD; +//TODO review remaining datatypes +import org.apache.plc4x.java.api.value.*; + + + +public class Plc4xCommon { + Review comment: javadoc is in the wrong place here, move it to before the method signature. is this still *could*? isn't it what we are doing now? ########## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/util/Plc4xCommon.java ########## @@ -0,0 +1,149 @@ +package org.apache.plc4x.nifi.util; +import java.util.Map; + +import org.apache.avro.Schema; +import org.apache.avro.SchemaBuilder; +import org.apache.avro.SchemaBuilder.FieldAssembler; +import org.apache.plc4x.java.api.value.PlcValue; +import org.apache.plc4x.java.spi.values.PlcBOOL; +import org.apache.plc4x.java.spi.values.PlcBYTE; +import org.apache.plc4x.java.spi.values.PlcBigDecimal; +import org.apache.plc4x.java.spi.values.PlcBigInteger; +import org.apache.plc4x.java.spi.values.PlcBitString; +import org.apache.plc4x.java.spi.values.PlcCHAR; +import org.apache.plc4x.java.spi.values.PlcDATE; +import org.apache.plc4x.java.spi.values.PlcDATE_AND_TIME; +import org.apache.plc4x.java.spi.values.PlcDINT; +import org.apache.plc4x.java.spi.values.PlcDWORD; +import org.apache.plc4x.java.spi.values.PlcIECValue; +import org.apache.plc4x.java.spi.values.PlcINT; +import org.apache.plc4x.java.spi.values.PlcLINT; +import org.apache.plc4x.java.spi.values.PlcLREAL; +import org.apache.plc4x.java.spi.values.PlcLTIME; +import org.apache.plc4x.java.spi.values.PlcLWORD; +import org.apache.plc4x.java.spi.values.PlcList; +import org.apache.plc4x.java.spi.values.PlcNull; +import org.apache.plc4x.java.spi.values.PlcREAL; +import org.apache.plc4x.java.spi.values.PlcSINT; +import org.apache.plc4x.java.spi.values.PlcSTRING; +import org.apache.plc4x.java.spi.values.PlcSimpleValue; +import org.apache.plc4x.java.spi.values.PlcStruct; +import org.apache.plc4x.java.spi.values.PlcTIME; +import org.apache.plc4x.java.spi.values.PlcTIME_OF_DAY; +import org.apache.plc4x.java.spi.values.PlcUDINT; +import org.apache.plc4x.java.spi.values.PlcUINT; +import org.apache.plc4x.java.spi.values.PlcULINT; +import org.apache.plc4x.java.spi.values.PlcUSINT; +import org.apache.plc4x.java.spi.values.PlcValueAdapter; +import org.apache.plc4x.java.spi.values.PlcValues; +import org.apache.plc4x.java.spi.values.PlcWCHAR; +import org.apache.plc4x.java.spi.values.PlcWORD; Review comment: remove comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org