ottobackwards commented on a change in pull request #257:
URL: https://github.com/apache/plc4x/pull/257#discussion_r739580930
##########
File path:
plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/BasePlc4xProcessor.java
##########
@@ -89,13 +110,13 @@ String getAddress(String field) {
@Override
public final List<PropertyDescriptor> getSupportedPropertyDescriptors() {
- return descriptors;
+ return properties;
}
@OnScheduled
public void onScheduled(final ProcessContext context) {
- PropertyValue property =
context.getProperty(PLC_CONNECTION_STRING.getName());
- connectionString = property.getValue();
+ //TODO add .evaluateAttributeExpressions()
+ connectionString =
context.getProperty(PLC_CONNECTION_STRING.getName()).getValue();
Review comment:
This still needs to be addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
