chrisdutz commented on a change in pull request #265:
URL: https://github.com/apache/plc4x/pull/265#discussion_r762417456
##########
File path: protocols/ads/src/main/resources/protocols/ads/ads.mspec
##########
@@ -281,7 +281,8 @@
// 4 bytes The ADS server checks if the value changes in this time
slice. The unit is 1ms
[simple uint 32 'cycleTime']
// 16bytes Must be set to 0
- [reserved uint 128 '0x0000' ]
+ [reserved uint 64 '0x0000' ]
Review comment:
I changed that because I was running into problems ... so I wasn't
randomly changing things ;-) In this case I thought fixing it wans't worth the
effort. I mean .... it's for writing 16 zero bytes ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
