hutcheb commented on code in PR #892: URL: https://github.com/apache/plc4x/pull/892#discussion_r1163546414
########## plc4j/integrations/apache-kafka/README.md: ########## Review Comment: I don't have any major objections to including a docker-compose file based off the Confluent images. ########## plc4j/integrations/apache-kafka/docker-compose.yml: ########## @@ -0,0 +1,101 @@ +version: '3' Review Comment: It looks like you've used a mix of confluent versions, latest, 6.0.0 and 6.0.1. 6.0.1, is also far from the latest (7.3.3) It also might be nicer to have the PLC4X version as an environment variable so it is easier to find when changing it for a release. I'm guessing you've grabbed a base docker-compose file from Confluent, can you confirm where you got it from so that we can check what license it was released under? ########## plc4j/integrations/apache-kafka/README.md: ########## @@ -234,3 +234,11 @@ between the base schemas. The schemas for the sink and source connectors are the same. This allows us to producer from one PLC and send the data to a sink. + + +### Start with Docker +If you want to use PLC4x with Kafka on Docker, simply download the docker-compose.yml file, configure the necessary port and IP settings, and start the containers. The available docker-compose.yml file includes four containers: zookeeper, kafka, kafka connect, and control-center. The control-center container provides a web interface to facilitate the configuration of kafka connect. If you don't want to use it, you can remove it from the docker-compose.yml file. Review Comment: Minor Formatting with PLC4x, should be PLC4X -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
