-1 (binding)

Found the mentioned issue and can confirm that I can not build from source.

Lukas

[OK] Download all staged artifacts under the url specified in the release
vote email.
[OK] Verify the signature is correct.
[OK] Check if the signature references an Apache email address.
[OK] Verify the SHA512 hashes.
[OK] Unzip the archive.
[OK] Verify the existence of LICENSE, NOTICE, README, RELEASE_NOTES files
in the extracted source bundle.
[MINOR] Verify the content of LICENSE, NOTICE, README, RELEASE_NOTES files
in the extracted source bundle.

  *   It turns out the “build with everything” statement needs an
additional “update-generated-code” profile to really build everything.

Am Fr., 16. Feb. 2024 um 14:56 Uhr schrieb Christofer Dutz <
christofer.d...@c-ware.de>:

> Found an issue … will fix it and stage an RC2
>
> Chris
>
> Von: Christofer Dutz <christofer.d...@c-ware.de>
> Datum: Freitag, 16. Februar 2024 um 14:54
> An: dev@plc4x.apache.org <dev@plc4x.apache.org>
> Betreff: AW: [VOTE] Apache PLC4X 0.12.0 RC1
> -1 (binding)
>
> Chris
>
> [OK] Download all staged artifacts under the url specified in the release
> vote email.
> [OK] Verify the signature is correct.
> [OK] Check if the signature references an Apache email address.
> [OK] Verify the SHA512 hashes.
> [OK] Unzip the archive.
> [OK] Verify the existence of LICENSE, NOTICE, README, RELEASE_NOTES files
> in the extracted source bundle.
> [MINOR] Verify the content of LICENSE, NOTICE, README, RELEASE_NOTES files
> in the extracted source bundle.
>
>   *   It turns out the “build with everything” statement needs an
> additional “update-generated-code” profile to really build everything.
> [OK] [RM] Verify the staged source README, RELEASE_NOTE files correspond
> to those in the extracted source bundle.
> [OK] [RM] Run RAT externally to ensure there are no surprises.
> [FAIL] Search for SNAPSHOT references
>
>   *   It seems the code-generation tests were not run during the release
> and therefore the artifacts there were not updated :-/
> [OK] Search for Copyright references, and if they are in headers, make
> sure these files containing them are mentioned in the LICENSE file.
> [-] Build the project according to the information in the README.md file.
> [-] [RM] Build the project with all with-xyz profiles and tests enabled
> and an empty maven local repo.
>
>
> Von: Christofer Dutz <christofer.d...@c-ware.de>
> Datum: Freitag, 16. Februar 2024 um 13:58
> An: dev@plc4x.apache.org <dev@plc4x.apache.org>
> Betreff: [VOTE] Apache PLC4X 0.12.0 RC1
> Apache PLC4X 0.12.0 has been staged under [2] and it’s time to vote
> on accepting it for release. All Maven artifacts are available under [1].
> Voting will be open for 72hr.
>
> A minimum of 3 binding +1 votes and more binding +1 than binding -1
> are required to pass.
>
> Release tag: v0.12.0
> Hash for the release tag: 90fc8c00de051abcad2789d7622c8d497209def4
>
> Per [3] "Before voting +1 PMC members are required to download
> the signed source code package, compile it as provided, and test
> the resulting executable on their own platform, along with also
> verifying that the package meets the requirements of the ASF policy
> on releases."
>
> You can achieve the above by following [4].
>
> [ ]  +1 accept (indicate what you validated - e.g. performed the non-RM
> items in [4])
> [ ]  -1 reject (explanation required)
>
>
> [1] https://repository.apache.org/content/repositories/orgapacheplc4x-1052
> [2] https://dist.apache.org/repos/dist/dev/plc4x/0.12.0/rc1
> [3] https://www.apache.org/dev/release.html#approving-a-release
> [4]
> https://cwiki.apache.org/confluence/display/PLC4X/Validating+a+staged+Release
>

Reply via email to