splatch commented on code in PR #1727:
URL: https://github.com/apache/plc4x/pull/1727#discussion_r1738448854
##########
plc4j/spi/src/main/java/org/apache/plc4x/java/spi/ConversationContext.java:
##########
@@ -149,7 +149,7 @@ interface ContextHandler {
void cancel();
- void awaitResponse() throws InterruptedException, ExecutionException;
+ void await() throws InterruptedException, ExecutionException;
Review Comment:
We use same context for server side/simulators. This statement is applicable
to `expectRequest()` thus renaming it to `await` makes it more generic and
match various roles implied by use of API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
