DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=43247>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43247 ------- Additional Comments From [EMAIL PROTECTED] 2007-09-08 09:13 ------- Patch applied. Thanks for it. However, I will close this bug only when I see unit tests for low-level record classes: src/scratchpad/src/org/apache/poi/hslf/record/ExOleObjStg.java src/scratchpad/src/org/apache/poi/hslf/record/ExOleObjAtom.java src/scratchpad/src/org/apache/poi/hslf/record/ExEmbedAtom.java src/scratchpad/src/org/apache/poi/hslf/record/ExEmbed.java A minimal unit test should take a reference data from a ppt file and verify getters/setters against it. See unit tests in src/scratchpad/testcases/org/apache/poi/hslf/record and follow the pattern. Ideas for further development: (1) it should be possible to access OLE object properties contained in ExEmbed container. Did you figure out how to link ExOleObjStg and the corresponding ExEmbed? My guess is that the order of ExEmbed in Document.ExObjList corresponds to the order of ExOleObjStg records. That is for the 1st ExOleObjStg we take the 1st Document.ExObjList.ExEmbed, etc. Any thoughts? (2) I think OLE shapes should be instances of OLEObjectShape extends SimpleShape. User code may look something like this: Shape[] shape = slide.getShapes(); for (int i=0; i,shape.length; i++){ if(shape[i] instanceof OLEObjectShape){ OLEObjectShape obj = (OLEObjectShape)shape[i]; ObjectData data = obj.getObjectData(); //shoule be able to access object properties String clipboardName = obj.getClipboardName(); if(clipboardName.equals("Microsoft Office Excel Worksheet")){ //do something with the data } } } (3) Can we construct a workbook or a presentation given the binary data retrieved from ObjectData.getData()? Regards, Yegor -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
