DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUGĀ·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42844>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED ANDĀ·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42844


[EMAIL PROTECTED] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From [EMAIL PROTECTED]  2007-09-13 12:11 -------
I see what's missing.
We borrowed the code from RecordFactory.CreateRecords but forgot to handle
unknown records that happen to be continued.

In RecordFactory.CreateRecords this piece of code looks as follows:

  if (lastRecord instanceof UnknownRecord) {
    //Gracefully handle records that we dont know about,
    //that happen to be continued
    records.add(record);
  } else 
    throw new RecordFormatException("Unhandled Continue Record");
  }


In HSSFEventFactory it should be like this:

  if (rec instanceof UnknownRecord) {
     ;//silently skip records we don't know about
  } else {
    throw new RecordFormatException("Records should handle ContinueRecord
internally. Should not see this exception");
  }

With this change it works without complains. I included the provided excel file
in the unit test. 

Regards,
Yegor


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to