https://issues.apache.org/bugzilla/show_bug.cgi?id=30311





--- Comment #10 from Josh Micich <[EMAIL PROTECTED]>  2008-03-30 22:27:12 PST 
---
(In reply to comment #9)
> unit test for HSSFConditionalFormatting and fixes

Added this patch in svn r642878.

I did some other clean-up (mostly for better encapsulation).  Please review,
and let me know if there is anything wrong.

POI is mostly coded in a way that reading an XLS file and rewriting it will
have no ill-effects.  It seems like the conditional formatting stuff mostly
obeys this principle.  However, writing a new XLS file or adding conditional
formatting to an existing XLS file might need a bit of work.

I found two bugs in CFRuleRecord (which have been fixed and have junits now): 
The 'undocumented' bits of the options field need to be set to zero (as far as
I can tell).  Setting them all to one causes Excel to report errors when
reading the generated file.  Another problem was that the wrong formula length
field was being set when formula2 was changed.

Another test I tried but gave up on, was to create some conditional formatting
using a FontFormatting object.  It seems that POI doesn't generate proper XLS
files when this feature is used.  The 118 byte data generated is quite
different to the one generated by Excel (if you attempt to make the formatting
the same).


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to