Hello David,
>  ...
>  The bug you just fixed that Yegor submitted was meant to fix this same
>  type of issue, but in our case it is Factset and not Bloomberg.
>
>  If this is broken, I am highly interested in solving this immediately.
>  ...
The patch for bug 44695 fixed re-serialization of the
ExternalNameRecord.  The added methods in TestExternalNameRecord show
the essence of the bug exposed by Yegor's attached sample code
(https://issues.apache.org/bugzilla/attachment.cgi?id=21723 and
https://issues.apache.org/bugzilla/attachment.cgi?id=21725)

>From what I understand, *this* issue is concerned with encoding new
calls to add-in functions, which POI does not support yet.  The
changes would be in the method call hierarchy of FormulaParser.parse()
(note- this is not called in Yegor's example). When encountering an
unknown function, the formula parser needs to decide whether it is
from the current workbook (not sure yet what this means), or from an
external workbook (like an add-in).  There may be some extra method
added to HSSFWorkbook to tell it what external workbooks are being
used (i.e. to create the SUPBOOK-0x1AE record).  Once the the right
SUPBOOK is created or located, the the formula parser can find or
create the ExternalNameRecord and finally create a NameXPtg formula
token.

BTW - can you make it clear how to access 'Factset' / 'Bloomberg'?  Am
I correct in assuming that they have the same architecture as the
'Analysis Toolpack'?

If Yegor's example had have had a call like:
  cell.setCellFormula("FDS(A1,\"FG_MKT_VALUE(\"&A1&\")\"))");
the written spreadsheet would have an error similar to that of *this*
issue.  But if you only use POI to read such formulas, or to
re-serialise a spreadsheet without touching those formulas, the fix
for bug 44695 is all you need.

It's going to take more than a few hours work to fix this issue.
Perhaps a bugzilla entry should be created to track the work.

-josh

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to