https://issues.apache.org/bugzilla/show_bug.cgi?id=47403
Josh Micich <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO --- Comment #1 from Josh Micich <[email protected]> 2009-06-22 17:09:37 PST --- Thanks for the patch. Adding the method insertCell() to HSSFRow is a good idea. I'm not sure however that the proposed optimisation is appropriate, given that it seems to be motivated by a method that isn't present yet. I did a quick performance test, running the existing 997 junits six times, with and without the change. My results show a degradation of about 5% (times in seconds): poi trunk (8.781, 9.375, 8.453, 8.453, 8.484, 8.453) with change (9.078, 9.156, 9.125, 9.203, 9.047, 9.094) Hopefully the POI unit tests are a fair representation of general POI usage (they *should* be, because many were based on example code posted to bugzilla). I guess HSSFRow was written assuming that client code would generally use random access to read the cells. If you could re-do the patch just for HSSFRow.insertCell(), that is likely to get applied. However the optimisation needs more justification/tweaking. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
