https://issues.apache.org/bugzilla/show_bug.cgi?id=47479


Josh Micich <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #1 from Josh Micich <[email protected]>  2009-07-06 13:06:27 PST 
---
I think the mistake is in OOO Calc - line 651 of xetable.cxx:
(http://svn.services.openoffice.org/ooo/trunk/sc/source/filter/excel/xetable.cxx)
This is inconsistent with the documentation.

I would propose this fix:

Index: xetable.cxx
===================================================================
--- xetable.cxx (revision 268869 ( 
https://svn.apache.org/viewcvs.cgi?view=rev&rev=268869 ))
+++ xetable.cxx (working copy)
@@ -648,7 +648,7 @@

 void XclExpBooleanCell::WriteContents( XclExpStream& rStrm )
 {
-    rStrm << sal_uInt16( mbValue ? 1 : 0 ) << EXC_BOOLERR_BOOL;
+    rStrm << sal_uInt8( mbValue ? 1 : 0 ) << EXC_BOOLERR_BOOL;
 }

 //
----------------------------------------------------------------------------


I guess Excel is able to read the file because the desired value of 0
(==EXC_BOOLERR_BOOL) still gets written to the second data byte.  


Fixed in svn r791595 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=791595 )

I wrote a unit test to reproduce the problem and also modified POI to tolerate
the OOO Calc bug.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to