https://issues.apache.org/bugzilla/show_bug.cgi?id=47520





--- Comment #3 from Roberto Manicardi <[email protected]>  2009-07-14 
06:22:51 PST ---
Yegor

> - Did you make any changes to XSSFFactory?  I guess you did, otherwise
> workbook.getRelations()  would never return instances of MapInfo. Please
> re-attach the full diff. 

XSSFFactory delegates to XSSFRelation the goal of choosing the right relation
class to instantiate. The new relation classes were added in the XSSFRelation
class

> - Please normalize your code to use org.apache.poi.ss.util.CellReference
> instead of XSSFCellReference. The latter class is redundant. 

Mmm, I've reinvented the wheel! :)
I'll send a new version of the patch


>  - Can you provide an example based on the posted code so that we include it 
> in
> the XSSF examples? It would be very handy.

I've added three XLSX examples in src/testcases/org/apache/poi/hssf/data
directory (it's the one where XSSFTestDataSamples searches for test files)
- Custom XML complex type.xlsx
- CustomXmlMappings-inverse-order.xlsx
- CustomXMLMappings.xlsx

You can find also some examples in the test class
org.apache.poi.xssf.extractor.TestXSSFExportToXML


Thank for your feedback,
Roberto

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to