https://issues.apache.org/bugzilla/show_bug.cgi?id=49432

           Summary: CommentsTable.getCTComment() has poor performance
           Product: POI
           Version: 3.6
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: XSSF
        AssignedTo: [email protected]
        ReportedBy: [email protected]


CommentsTable.getCTComment() always goes over all comments. Run time is O(n^2).
In large Excel file when checking if cell has warning a total time that spent
in this method can take many minutes.
By keeping the table in Map<String, CTComment> where key is comment.getRef()
the run time imporved dramatically.
Also in XSSFSheet.read() method inside condition "if(p instanceof
CommentsTable)" there is no "break" which should stop unnecessary processing.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to