https://issues.apache.org/bugzilla/show_bug.cgi?id=49919

           Summary: Implement support for BorderCode
           Product: POI
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: HWPF
        AssignedTo: [email protected]
        ReportedBy: [email protected]


I'd like to finish implementation and create a patch for BorderCodes. Currently
it reads only the Word 97 structure (4-byte), and the class does not provide
any getters or setters. Word 2000 and above use new 8-byte version, which is
changed in new SPRM, which are currently not processed.

I don't know how to do it best in regard of backward compatibility. Two
BorderCode structures should be supported. They have the same properties,
except for color, which is changed from 8-bit to 24-bit in word 2000.

I suggest this:
1. rename existing BorderCode to BorderCode97 and create new BorderCode2000.
These will read/write values as appropriate for particular version.
2. create new class BorderCode, which will delegete to BorderCode97 or
BorderCode2000. Will provide method returning boolean as whether 8 or 24-bit
color is valid. It will not contain following public methods from current
implementation: 
  - the public contructor
  - the toInt method
As such it will not be full backwards compatible, but I think this is not the
issue, as currently the class is useless.

Note, that there are different BorderCode structures for Word 95 and Word 1.0,
but as I understand, we do not support these.

Please let me know.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to