https://issues.apache.org/bugzilla/show_bug.cgi?id=51171
--- Comment #5 from Marcel May <[email protected]> 2011-05-25 14:22:29 UTC --- (In reply to comment #4) > Fixed in r1103502, but in a diffrent way. > > The real problem was that HSSFCell.setCellStyle was called for every cell when > constructing a workbook. This method is expensive and designed for assigning > styles to individual cell and applying it to workbook scope causes performance > issues. It appears that we don't need to call setCellStyle in the HSSFCell > constructior at all, this line remained from all times (POI-3.5 or earlier) > and > does not make any sense in POI-3.8. So, I removed it. > > This fix should boost performance of opening .xls files even greater than > ~1.3. > > Yegor Thanks, Yegor - your fix was even better :-) I profiled again against latest version 1127506 and noticed another hotspot in the SharedValueManager class. Here's an 8 million times iteration doing 'findFormularGroup'. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
