Hello All,
I'm Kalyan and I have recently joined the dev group. I'm a software engineer
by profession and have 6+ years of experience in Java programming. I have
checkout the code today.. and here are some of my intial findings for
improving the quality of code for POI.
- The following variables may not be needed in the method stack ( though
method call in the same line may be needed in few cases)
In EscherChildRecordAnchor.java, Variable: bytesRemaining @ Line 40
HSSFWorkbook.java, Variable: font @ Line 1064
EncryptionInfo.java Variable: hSize @ Line 61. (This method call also
may not be needed as it is not updating any instance data)
HSSFName.java Variable: oldName @ Line 153. (This method call also may
not be needed as it is not updating any instance data)
PolygonShape.java Variable: shape @ Line 132.
EcmaDecryptor.java Variable: size @ Line 128.
- All the toString() implementations can now be updated to StringBuilder
from StringBuffer.
- SSTRecord.java Line 295. The same null check is being done two times.
Please let me know I can send the updated files for the same email id or a
Committor can have a look at them.
I'm looking forward to contribute to the best of my capabilities.
Regards,
Kalyan
