https://issues.apache.org/bugzilla/show_bug.cgi?id=51716

             Bug #: 51716
           Summary: Incorrect assert in
                    SXSSFSheet#getSXSSFSheet(XSSFSheet)
           Product: POI
           Version: 3.8-dev
          Platform: PC
            Status: NEW
          Severity: minor
          Priority: P2
         Component: SXSSF
        AssignedTo: dev@poi.apache.org
        ReportedBy: mark.har...@zuhlke.com
    Classification: Unclassified


Created attachment 27430
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=27430
Removes an assert from SXSSFWorkbook.java

Workbook#getSheet(String) explicitly states that it should return null if
workbook does not contain a sheet with the name given.

In 3.8-beta3 and the trunk, SXSSFWorkbooks implementation of getSheet(String)
calls getSXSSFSheet(XSFFSheet), which contains an assert (:68 in 3.8-beta3)
that the result of a Map lookup on the string isn't null.

This makes getSheet(String) no good for an existence check on a named sheet if
the JVM has been run with -ea.

I've attached a patch that removes the assert from the current trunk.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Reply via email to