https://issues.apache.org/bugzilla/show_bug.cgi?id=51961

Yegor Kozlov <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Yegor Kozlov <[email protected]> 2011-12-09 11:21:17 UTC ---
Committed in r1212330

Santosh,

When I suggested passing a subclass of SheetDataWriter I didn't realize the
complications. Since each sheet uses its own instance of SheetDataWriter you
pass the class name instead of an instance and this is not good in my opinion. 

I re-worked the patch and used your original idea: pass a flag to
SXSSFWorkbook.
In current implementation the gzip compression is turned on as follows:

        SXSSFWorkbook wb = new SXSSFWorkbook();
        wb.setCompressTempFiles(true); // temp files will be gzipped

I think it is much more user-friendly than passing a class name in the
constructor. Sorry that my previous suggestion mislead you. 

In any case, thank you for the patch. You've written 90% of it and I just put
it in a slightly different shape. 


Regards,
Yegor

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to