+1.

I have some reservations for a FINAL release.

(1) When I check the signature of the tar.gz packages. I have to gunzip and 
change the name of the gpg.

(2) Sometimes the tests fail with:

    [junit] Running org.apache.poi.hssf.usermodel.TestBugs
    [junit] Invalid memory access of location 0x8 rip=0x10113a9bc
    [junit] 
    [junit] Running org.apache.poi.util.TestTempFile
    [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0 sec

BUILD FAILED
/Users/dave/Documents/poi-3.8beta5/poi-3.8-beta5-src-zip/build.xml:630: Tests 
failed (crashed)

This could be something related to my configuration on my Mac.

(3) The build should make sure the character encoding is not ASCII, or change 
this test case.

    [javac] 
/Users/dave/Documents/poi-3.8beta5/poi-3.8-beta5-src-tar/src/ooxml/testcases/org/apache/poi/xslf/extractor/TestXSLFPowerPointExtractor.java:192:
 warning: unmappable character for encoding ASCII
    [javac]          "And onto the 4th, such fun???.\n" +
    [javac]                                     ^
    [javac] 
/Users/dave/Documents/poi-3.8beta5/poi-3.8-beta5-src-tar/src/ooxml/testcases/org/apache/poi/xslf/extractor/TestXSLFPowerPointExtractor.java:192:
 warning: unmappable character for encoding ASCII
    [javac]          "And onto the 4th, such fun???.\n" +
    [javac]                                      ^
    [javac] 
/Users/dave/Documents/poi-3.8beta5/poi-3.8-beta5-src-tar/src/ooxml/testcases/org/apache/poi/xslf/extractor/TestXSLFPowerPointExtractor.java:192:
 warning: unmappable character for encoding ASCII
    [javac]          "And onto the 4th, such fun???.\n" +
    [javac]                                       ^
    [javac] Note: Some input files use or override a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
    [javac] 3 warnings

We can discuss this in the next few weeks.

Regards,
Dave


On Dec 10, 2011, at 8:19 AM, Yegor Kozlov wrote:

> Hi All,
> 
> Please test-drive the release candidate for POI 3.8 beta5.
> 
> The release candidate files were built from the REL_3_8_BETA5 tag and
> are available from:
> 
> https://dist.apache.org/repos/dist/dev/poi/
> 
> As with all Apache release votes, please check that not only does the
> code work, and no major breakages have occurred since the last
> release, but also that packaging is correct, license headers and
> notices exist etc.
> 
> The vote options are:
> 
> +1 - I support this release
> 0   - I don't object to this release, but I haven't checked it
> -1  - There's a problem with the release, and that is ....
> 
> I'm voting [+1]. Voting will last one week and end on Saturday, 17th December.
> 
> Yegor Kozlov
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to