https://issues.apache.org/bugzilla/show_bug.cgi?id=53058
--- Comment #8 from Yegor Kozlov <[email protected]> 2012-04-14 10:14:47 UTC --- Very cool. It is nearly complete in my opinion, I only have two things to say: 1. Complete the use case : modify the source workbook with POI. Call sheet.getDrawingPatriarch() for each sheet, save the result and run BiffDrawingToXml. We expect that the output will be identical to the source but I guess it will be not. 2. RecordId, Version and Instance are record attributes (as opposed to the record body) and they ought to be XML attributes instead of child nodes: <EscherClientAnchorRecord recordId="0xF010" version"0x00" instance="0x00"> ... </EscherClientAnchorRecord> This way we clearly separate record attributes (i.e record header) from the record body. Other than that, very cool. Regards, Yegor (In reply to comment #7) > Hi, I have updated patch according to your advices. > Also I have updated target xml file. > > I look forward to your feedback. > With best regards, Evgeniy Berlog -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
