https://issues.apache.org/bugzilla/show_bug.cgi?id=54982

Dominik Stadler <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30286|0                           |1
        is obsolete|                            |
                 CC|                            |[email protected]

--- Comment #4 from Dominik Stadler <[email protected]> ---
Created attachment 30337
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30337&action=edit
Different approach adding a close() to the POITextExtractor and implementing it
in a few sub-classes

Hi, a close() sounds fine to me. I have created a patch which adds a close()
interface to POITextExtractor which can be used to free resources later. I have
implemented the close() in all classes that seem to make use of
closeable-resources. It also adds calls to close() in tests and runs existing
unit tests for XSSF-extractors also against the Extractor that is built via the
Factory. Finally it also add a small test-suite to quickly execute all
extractor-related tests.

Regarding updated documentation, I think that is fine and should it make easier
to spot the state of Extractors.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to