https://issues.apache.org/bugzilla/show_bug.cgi?id=54849

--- Comment #15 from Tim Allison <[email protected]> ---
Nick, Great.  Thank you!

On the authorship attribution, I was following the checklist
(http://poi.apache.org/guidelines.html) 
•the code includes the @author tag on any files you've altered or created.

I completely agree with you, though, and will remove author tags.

I don't wnat to take up your time with the spacing.  I'd like to get the
spacing right.  Is the issue too many newlines/deleted new lines, or did I
convert tabs to spaces or add too many spaces per line?  Or are both going on? 
I'll repull and run the patch against the pull to see, but if you could offer
feedback, that'd be great.

Finally, at the end of the Round 3 patch, I realized that I left one case not
covered: a table cell can be equivalent to an SDT.  Should I add that in the
same way that I've added the equivalence to paragraphs and runs?  Or should I
save that for a follow on patch? My preference is that the current version
(with space/author attrib fixed) be committed asap, and then I'll do some
follow on work.  Let me know your preference.

Thank you, again.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to