Hi,

I did a number of local tests with Java 1.5, compiling still works fine as
long as Ant is not too new (i.e. 1.8.x seems to be compiled with Java 6
already).

I also reviewed all the maven template-files, none of them references or
uses junit as far as I saw.

Therefore I committed the change, let me know if there is any problem with
it.

Thanks... Dominik.


On Mon, Jun 24, 2013 at 8:57 AM, Yegor Kozlov <[email protected]> wrote:

> POI is compatible with JDK 1.5, this is the main reason we keep using
> Junit 3.x.
>
> Can you test a combination of JUnit  4.11 and JDK 1.5 ? If it works,
> then we can consider the upgrade.
>
> Yegor
>
> On Mon, Jun 24, 2013 at 2:02 AM, Dominik Stadler <[email protected]>
> wrote:
> > Hi,
> >
> > I did run into problems when running unit tests in POI with a newer
> version
> > of Ant, see my related stackoverflow question
> >
> > Is there any reason why POI is not using a newer JUnit version? I locally
> > upgraded to 4.11 some time ago and was able to run all unit tests
> > successfully, therefore I would like to apply the attached patch, please
> let
> > me know if there is something that requires junit 3.x here!
> >
> > A second small addition to the build.xml that I propose is to use a
> property
> > for the test-case expression, thus allowing to run single unit tests on
> the
> > commandline with "ant -Dtestpattern=XYZ test"
> >
> > Thanks... Dominik.
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [email protected]
> > For additional commands, e-mail: [email protected]
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
>

Reply via email to