Sounds like a good idea to me.
>________________________________ > From: "Allison, Timothy B." <[email protected]> >To: POI Developers List <[email protected]> >Sent: Monday, July 29, 2013 3:51 PM >Subject: RE: modify XSSFTestDataSamples.writeOutAndReadBack to write to >directory specified by optional sys prop? > > >Sorry, to clarify, I'd add a function with a different signature: > >writeOutAndReadBack(R wb, String testName) > >(where testName is used as the name of the file) > >Devs could then choose to call that one or the original: > >writeOutAndReadBack(R wb) > > >-----Original Message----- >From: Allison, Timothy B. [mailto:[email protected]] >Sent: Monday, July 29, 2013 10:40 AM >To: POI Developers List ([email protected] >Subject: modify XSSFTestDataSamples.writeOutAndReadBack to write to directory >specified by optional sys prop? > >POI Dev Community, > The patch for 55294 >(https://issues.apache.org/bugzilla/show_bug.cgi?id=55294) includes a handy >option to write files to the directory set by the system property >"poi.test.xssf.output.dir" in writeOutAndReadBack. If the property is not >set, it backs off to the traditional XSSFTestDataSamples.writeOutAndReadBack. >This seems to me like an elegant way of dumping created/modified files for >manual review by opening in Excel or other ooxml tool...if you want this >behavior, set the system property, if not, don't. > As part of applying patch 55294, should I generalize this behavior and >modify XSSFTestDataSamples.writeOutAndReadBack to do this? > > Thank you. > > Best, > > Tim > >--------------------------------------------------------------------- >To unsubscribe, e-mail: [email protected] >For additional commands, e-mail: [email protected] > > >
