https://issues.apache.org/bugzilla/show_bug.cgi?id=51585
--- Comment #21 from Piotr Wilkin <[email protected]> --- (In reply to Nick Burch from comment #18) > It would be great if someone could confirm if the new patch does fix all the > problems flagged against the original, and also if someone could try > applying the patch(es) and confirm if all the unit tests still pass, > behaviour is correct etc. Those two would greatly speed up the review/accept > cycle for getting this applied! Let me clarify: The original bug report dealt with the WorkbookFactory.create() call hanging on files with many columns. This was later determined to be simply a complexity issue with slow code in the ColumnHelper. I made a fix that redoes the ColumnHelper with an efficient algorithm (based on sweeping, see http://en.wikipedia.org/wiki/Sweep_line_algorithm) while still preserving the functionality of the original. I also made sure that the new algorithm passes all unit tests. In the one case where the original tests were not passed, I debugged it on a case-by-case basis to make sure the new behavior was correct. Seeing as the relevant testing code has a comment by the lines of "I'm not really sure how this is supposed to work", I do believe that the new behavior is actually the correct one. I don't think I have the necessary access level needed to push this onto SVN, which is I left the patch on the NEEDINFO status. Hopefully, if some developer verifies this and pushes this to SVN, it can be changed to RESOLVED. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
