On Sun, 2 Feb 2014, [email protected] wrote:
public final class PackageRelationshipCollection implements - Iterable<PackageRelationship> { + Iterable<PackageRelationship> {private static POILogger logger = POILogFactory.getLogger(PackageRelationshipCollection.class); - /** - * Package relationships ordered by ID. - */
Minor thing, but if you find yourself working on a file with inconsistent line endings / whitespace, it's generally better to do two commits. One commit to fix up the whitespace, a second for the actual logic changes.
If they're split out, then it's very easy to review the change from the diff email. If they go in together, reviewing means more faffing with svn diff to exclude whitespace, so it's a lot harder, and hence fewer people will review!
Nick --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
