https://bz.apache.org/bugzilla/show_bug.cgi?id=56017

Dominik Stadler <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #12 from Dominik Stadler <[email protected]> ---
I gave this a try and ended up changing the implementation of
XSSFSheet.shiftRows() quite a bit, see r1666843. 

The current code did not handle a few things well, e.g. removing comments in
overwritten rows and cases where comments are moved around. Moving the comments
while still iterating caused cases where comments where moved multiple times,
messing up things.

Also XSSFComment.setRow() was prone to a xmlbeans bug when resetting
row-nunmbers. 

A few new test-cases now verify the most common cases, please report new bugs
with sample code if there are still cases that are handled incorrectly.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to