https://bz.apache.org/bugzilla/show_bug.cgi?id=58525
--- Comment #1 from Javen ONeal <[email protected]> --- It looks like you're maintaining two data structures that contain essentially the same content, a List and a HashMap. In the interest of keeping POI's memory footprint down, would it be possible to use just one data structure? It might even be faster, since write operations wouldn't need to modify 2 data structures. > public LinkTable(int numberOfSheets, WorkbookRecordList workbookRecordList) { > _workbookRecordList = workbookRecordList; > _definedNames = new ArrayList<NameRecord>(); > _nameRecordMap = new HashMap<Integer, Map<String, NameRecord>>(); > ... > while(true) { > if (nextClass == NameRecord.class) { > NameRecord nr = (NameRecord)rs.getNext(); > _definedNames.add(nr); > addToNamesMap(nr); > } > } > public void removeBuiltinRecord(byte name, int sheetIndex) { > NameRecord record = getSpecificBuiltinRecord(name, sheetIndex); > if (record != null) { > _definedNames.remove(record); > removeFromNameRecordMap(record); > } > } -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
