https://bz.apache.org/bugzilla/show_bug.cgi?id=58787
Javen O'Neal <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO --- Comment #2 from Javen O'Neal <[email protected]> --- It looks like all the changes in patch.tar.gz/patch.txt were committed in bug 58633 and bug 58879. I think the two tests from TestCellUtil.java were committed as part of bug 58633. If not, could you rebase your changes, and rewrite to use junit4 instead of junit3? For CellBorder.java, you might want to use an enum here so that CellBorders can be used in switch statements in Java 6, and also improves code quality due to type checking. See SpreadsheetVersion's implementation if you need an example. For another example, see o.a.p.ss.usermodel.HorizontalAlignment. Functions in CellBorder.java should have unit tests before this is committed. Per comment 1, if creating unnecessary intermediate <border> elements is still an issue after bug 58633, please write a unit test for that. Thanks for the DrawingBorders example! ==== Side-note about JUnit testing in POI ==== You'll find two different flavors of unit tests in Apache POI There's junit3: import junit.framework.TestCase; public class TestSomeClass extends TestCase { public void testSomeMethod() { } } and junit4: import org.unit.Test; public class TestSomeClass { @Test public void testSomeMethod() { } } We're slowly trying to convert our junit3 tests over to junit4. There are a few reasons for this: * junit4 has new features that are more flexible * inheritance: we don't need to inherit from TestCase, making it easier to inherit from a base class that makes the tests more concise (see BaseTestWorkbook, TestXSSFWorkbook) * Don't need to build and maintain test suite classes--that is, classes that just list the TestCase classes to be run. New tests should be written in junit4. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
